Runs helm repeatedly for the same inputs

[iainlane]

I was just testing an export of all the environments in our repo and I noticed that when we have inline environments which end up using Helm charts, we run the Helm template separately for each environment.

Perhaps template runs (for the same Values) could be cached.

{"level":"debug","argv":["template","somechart","somechart","--values","-","--include-crds","--namespace=somechart"],"time":"2023-08-09T12:05:18+01:00","message":"running helm"}
{"level":"debug","argv":["template","somechart","somechart","--values","-","--include-crds","--namespace=somechart"],"time":"2023-08-09T12:05:20+01:00","message":"running helm"}
{"level":"debug","argv":["template","somechart","somechart","--values","-","--include-crds","--namespace=somechart"],"time":"2023-08-09T12:05:21+01:00","message":"running helm"}
{"level":"debug","argv":["template","somechart","somechart","--values","-","--include-crds","--namespace=somechart"],"time":"2023-08-09T12:05:23+01:00","message":"running helm"}
{"level":"debug","argv":["template","somechart","somechart","--values","-","--include-crds","--namespace=somechart"],"time":"2023-08-09T12:05:24+01:00","message":"running helm"}
{"level":"debug","argv":["template","somechart","somechart","--values","-","--include-crds","--namespace=somechart"],"time":"2023-08-09T12:05:26+01:00","message":"running helm"}

[julienduchesne]

Values could be different since they are piped

[iainlane]

Yes, they're piped by us, the values are known on Tanka's side:

tanka/pkg/helm/template.go

Lines 31 to 35 in 965612c

	data, err := yaml.Marshal(opts.Values)
	if err != nil {
	return nil, errors.Wrap(err, "Converting Helm values to YAML")
	}
	cmd.Stdin = bytes.NewReader(data)

(I have checked in this case and they are the same)