Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go version mismatch #954

Closed
zerok opened this issue Nov 13, 2023 · 0 comments · Fixed by #985
Closed

Go version mismatch #954

zerok opened this issue Nov 13, 2023 · 0 comments · Fixed by #985
Labels
docker Pull requests that update Docker code go Pull requests that update Go code kind/bug Something isn't working

Comments

@zerok
Copy link
Contributor

zerok commented Nov 13, 2023

There is currently a bit of a version mismatch regarding which Go version is used in the Docker image vs. in the binaries that are part of the GH releases. The Docker images are already on the latest 1.21 (as updated by Dependabot) while the binaries are on the latest 1.20 (due to the GH actions being hard-coded to that).

It would be awesome if there was a single source that specified which Go version to use and that is then used by both artifact-paths. Perhaps something like Dagger might help here?
@zerok zerok added kind/bug Something isn't working go Pull requests that update Go code docker Pull requests that update Docker code labels Nov 13, 2023
@zerok zerok mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker Pull requests that update Docker code go Pull requests that update Go code kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Use Dockerfile as source for the Go version zerok/tanka
1 participant
@zerok