Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable service monitors per TempoStack instance #333

Closed
andreasgerstmayr opened this issue Mar 21, 2023 · 0 comments · Fixed by #381
Closed

Enable/disable service monitors per TempoStack instance #333

andreasgerstmayr opened this issue Mar 21, 2023 · 0 comments · Fixed by #381
Assignees

Comments

@andreasgerstmayr
Copy link
Collaborator

ServiceMonitors should be enabled/disabled per TempoStack instance (in the observability field in the spec)

Follow-up of #324
Requires CRD changes of #299

@andreasgerstmayr andreasgerstmayr changed the title Enable/disable service monitor per TempoStack instance Enable/disable service monitors per TempoStack instance Mar 21, 2023
@andreasgerstmayr andreasgerstmayr self-assigned this Apr 12, 2023
andreasgerstmayr added a commit to andreasgerstmayr/tempo-operator that referenced this issue Apr 12, 2023
In the `.spec.observability.metrics.enabled` field of the TempoStack
spec.

Resolves: grafana#333
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr added a commit that referenced this issue Apr 14, 2023
* Enable ServiceMonitors per TempoStack instance

In the `.spec.observability.metrics.enabled` field of the TempoStack
spec.

Resolves: #333
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Fix metrics field path

Co-authored-by: Israel Blancas <iblancasa@gmail.com>

* Fix metrics field path (2)

Co-authored-by: Israel Blancas <iblancasa@gmail.com>

* rename spec.observability.metrics.enabled to spec.observability.metrics.createServiceMonitors

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Israel Blancas <iblancasa@gmail.com>
rubenvp8510 pushed a commit to rubenvp8510/tempo-operator that referenced this issue Apr 22, 2023
* Enable ServiceMonitors per TempoStack instance

In the `.spec.observability.metrics.enabled` field of the TempoStack
spec.

Resolves: grafana#333
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Fix metrics field path

Co-authored-by: Israel Blancas <iblancasa@gmail.com>

* Fix metrics field path (2)

Co-authored-by: Israel Blancas <iblancasa@gmail.com>

* rename spec.observability.metrics.enabled to spec.observability.metrics.createServiceMonitors

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Israel Blancas <iblancasa@gmail.com>
rubenvp8510 pushed a commit to rubenvp8510/tempo-operator that referenced this issue May 5, 2023
* Enable ServiceMonitors per TempoStack instance

In the `.spec.observability.metrics.enabled` field of the TempoStack
spec.

Resolves: grafana#333
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

* Fix metrics field path

Co-authored-by: Israel Blancas <iblancasa@gmail.com>

* Fix metrics field path (2)

Co-authored-by: Israel Blancas <iblancasa@gmail.com>

* rename spec.observability.metrics.enabled to spec.observability.metrics.createServiceMonitors

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>

---------

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Co-authored-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant