Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover resource.requests for manager pod #426

Closed
iblancasa opened this issue May 30, 2023 · 1 comment
Closed

Recover resource.requests for manager pod #426

iblancasa opened this issue May 30, 2023 · 1 comment

Comments

@iblancasa
Copy link
Collaborator

According to the the OpenShift conventions guide, we should recover the resources.requests field for the Tempo operator.

Therefore, cluster components SHOULD NOT be configured with resource limits.

However, cluster components MUST declare resource requests for both CPU and memory.
@iblancasa iblancasa changed the title Recover Recover resource.requests May 30, 2023
@iblancasa iblancasa changed the title Recover resource.requests Recover resource.requests for manager pod May 30, 2023
iblancasa added a commit to iblancasa/tempo-operator that referenced this issue May 30, 2023
@iblancasa
Recover the resource.requests as per OpenShift guidelines grafana#426
1d516c2 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa added a commit to iblancasa/tempo-operator that referenced this issue May 30, 2023
@iblancasa
Recover the resource.requests as per OpenShift guidelines grafana#426
e8470cd 
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa mentioned this issue May 30, 2023
Merged
andreasgerstmayr pushed a commit that referenced this issue May 30, 2023
@iblancasa
Recover the resource.requests as per OpenShift guidelines (#427)
b525965 
* Recover the resource.requests as per OpenShift guidelines #426

Signed-off-by: Israel Blancas <iblancasa@gmail.com>

* Add changelog

Signed-off-by: Israel Blancas <iblancasa@gmail.com>

---------

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@andreasgerstmayr
Copy link
Collaborator

Merged in #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreasgerstmayr @iblancasa