Fix TLS configuration of ServiceMonitors #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
fix-servicemonitor-tls
branch
from
a3939f2
to
b8bdbfe
Compare
|
Could you add something to the description explaining what is this PR fixing? Like the problem caused |
rubenvp8510
approved these changes
Jun 27, 2023
iblancasa
approved these changes
Jun 27, 2023
pavolloffay
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the location of the TLS certificates for the ServiceMonitors.
In #387 the certificate names were changed to
*-mtls, and becausenaming.Namewas used instead ofnaming.TLSSecretNameto get the certificate name, the ServiceMonitors used to point to non existing certificates.The PR also updates the gateway's TLS certificate location in the ServiceMonitor (depends on PR #480).