Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify log levels for all components #550

Merged

Conversation

andreasgerstmayr
Copy link
Collaborator

This makes it easier to change log levels for unmanaged TempoStack instances (i.e. for debugging), without needing to look up the name of the log level CLI flag of each component.

This makes it easier to change log levels for unmanaged TempoStack
instances (i.e. for debugging), without needing to look up the name
of the log level CLI flag of each component.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #550 (7f443a2) into main (0951f05) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   78.11%   78.19%   +0.07%     
==========================================
  Files          64       64              
  Lines        4707     4724      +17     
==========================================
+ Hits         3677     3694      +17     
  Misses        857      857              
  Partials      173      173              
Flag Coverage Δ
unittests 78.19% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/manifests/compactor/compactor.go 87.76% <100.00%> (+0.36%) ⬆️
internal/manifests/distributor/distributor.go 94.23% <100.00%> (+0.11%) ⬆️
internal/manifests/ingester/ingester.go 88.60% <100.00%> (+0.29%) ⬆️
internal/manifests/querier/querier.go 87.83% <100.00%> (+0.33%) ⬆️
internal/manifests/queryfrontend/query_frontend.go 90.93% <100.00%> (+0.02%) ⬆️

@andreasgerstmayr andreasgerstmayr merged commit eca5b6a into grafana:main Sep 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants