Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mTLS by default, to allow connections from Grafana to the query-frontend #560

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

andreasgerstmayr
Copy link
Collaborator

Disable mTLS by default, to allow connections from Grafana to the query-frontend component.

Resolves: #552

…ry-frontend component

Resolves: grafana#552
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #560 (e12913c) into main (8a3d8c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files          64       64           
  Lines        4707     4707           
=======================================
  Hits         3677     3677           
  Misses        857      857           
  Partials      173      173           
Flag Coverage Δ
unittests 78.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@andreasgerstmayr andreasgerstmayr enabled auto-merge (squash) August 16, 2023 16:01
Copy link
Collaborator

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please book a ticket to enable it back

@andreasgerstmayr andreasgerstmayr merged commit 6364f84 into grafana:main Aug 16, 2023
11 checks passed
@andreasgerstmayr
Copy link
Collaborator Author

Please book a ticket to enable it back

Sure: #561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query frontend should not be protected with mTLS when gateway is disabled
4 participants