Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release push to OLM in tempo-operator #583

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Aug 30, 2023

It will be good to merge first #681

Also I'm not sure how to test this before release

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5e2019) 78.22% compared to head (82cf853) 78.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          65       65           
  Lines        5024     5024           
=======================================
  Hits         3930     3930           
  Misses        907      907           
  Partials      187      187           
Flag Coverage Δ
unittests 78.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa
Copy link
Collaborator

Also I'm not sure how to test this before release

@rubenvp8510 I think you can do it from your fork (you will need to merge first to main in your fork).

- name: Checkout operatorhub repo
uses: actions/checkout@v3
with:
repository: grafana/${{ inputs.repo }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/reusable-operator-hub-release.yaml Outdated Show resolved Hide resolved
.github/workflows/reusable-operator-hub-release.yaml Outdated Show resolved Hide resolved
.github/workflows/reusable-operator-hub-release.yaml Outdated Show resolved Hide resolved
@rubenvp8510
Copy link
Collaborator Author

rubenvp8510 commented Sep 19, 2023

This should work in theory

In the practice I'm getting this error:

pull request create failed: GraphQL: Resource not accessible by integration (createPullRequest)

Still don't know what it means, the example App I used has all the permissions.

PR in forked repo rubenvp8510/community-operators#1

@rubenvp8510
Copy link
Collaborator Author

This is not gonna work, as the installation tokens only have read-only access to the public repos, means no PR creation. we need a PAT, I'm modifying this to make it work as same way OTel does.

@rubenvp8510 rubenvp8510 force-pushed the automate_olm branch 2 times, most recently from a400839 to 82cf853 Compare November 14, 2023 17:14
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@rubenvp8510
Copy link
Collaborator Author

rubenvp8510 commented Nov 15, 2023

This is ready and tested on my fork. the only requirement is to add the PAT to the TEMPOOPERATORBOT_GITHUB_TOKEN secret at repository level.

@rubenvp8510 rubenvp8510 merged commit 5a65f77 into grafana:main Nov 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants