Fix ingester StatefulSet reconciliation if ingester is in an unhealthy state #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 78.20% 78.12% -0.08%
==========================================
Files 64 65 +1
Lines 4781 4805 +24
==========================================
+ Hits 3739 3754 +15
- Misses 864 871 +7
- Partials 178 180 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
andreasgerstmayr
changed the title
andreasgerstmayr
force-pushed
the
reconcile-statefulset
branch
5 times, most recently
from
f9e1364
to
bd272e2
Compare
Changes to a StatefulSet are not propagated to pods in a broken state (e.g. CrashLoopBackOff) See kubernetes/kubernetes#67250 This is a workaround for the above issue. Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
reconcile-statefulset
branch
from
bd272e2
to
e5ae3b5
Compare
frzifus
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to a StatefulSet are not propagated to pods in a broken state (e.g. CrashLoopBackOff)
See kubernetes/kubernetes#67250
Related: #545 (for invalid certificates the ingester never got in a healthy state, and the pods were not updated even when a correct certificate was configured)
I also updated the upgrade test to check for a Ready condition of the TempoStack CR.