Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating Ingress and Route objects in the TempoMonolithic CR #755

Merged

Conversation

andreasgerstmayr
Copy link
Collaborator

@andreasgerstmayr andreasgerstmayr commented Jan 19, 2024

Support creating Ingress and Route objects in the TempoMonolithic CR.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 241 lines in your changes are missing coverage. Please review.

Comparison is base (db3e154) 77.76% compared to head (c945c51) 76.66%.
Report is 4 commits behind head on main.

Files Patch % Lines
controllers/tempo/tempomonolithic_controller.go 28.71% 62 Missing and 10 partials ⚠️
internal/manifests/monolithic/statefulset.go 77.13% 47 Missing and 4 partials ⚠️
internal/manifests/monolithic/configmap.go 52.87% 38 Missing and 3 partials ⚠️
apis/tempo/v1alpha1/tempomonolithic_webhook.go 50.00% 27 Missing and 1 partial ⚠️
controllers/tempo/common.go 61.90% 17 Missing and 7 partials ⚠️
internal/manifests/monolithic/build.go 65.38% 6 Missing and 3 partials ⚠️
internal/manifests/mutate.go 63.63% 6 Missing and 2 partials ⚠️
internal/manifests/monolithic/ingress.go 95.09% 5 Missing ⚠️
controllers/tempo/tempostack_create_or_update.go 71.42% 1 Missing and 1 partial ⚠️
controllers/tempo/tempostack_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   77.76%   76.66%   -1.11%     
==========================================
  Files          68       78      +10     
  Lines        5155     5859     +704     
==========================================
+ Hits         4009     4492     +483     
- Misses        949     1144     +195     
- Partials      197      223      +26     
Flag Coverage Δ
unittests 76.66% <69.26%> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr merged commit 5f2a83c into grafana:main Jan 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants