Use service duration query option in the jaeger query UI #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
changed the title
rubenvp8510
changed the title
pavolloffay
reviewed
Apr 29, 2024
| // | ||
| // +optional | ||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="ServicesQueryDuration" | ||
| ServicesQueryDuration *metav1.Duration `json:"servicesQueryDuration,omitempty"` |
There was a problem hiding this comment.
Can this feature be used without Jaeger query/ui?
There was a problem hiding this comment.
No, the tempo tags endpoint now have the ability to ask for a time range (my large PR that was merged sometime ago). But this is how the jaeger query used it to ask for the service. So this configuration is specific for jaeger-ui
rubenvp8510
force-pushed
the
add_ttl_to_services
branch
5 times, most recently
from
a430a42
to
76bef2f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 76.07% 76.07% -0.01%
==========================================
Files 93 93
Lines 5856 5859 +3
==========================================
+ Hits 4455 4457 +2
- Misses 1134 1135 +1
Partials 267 267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreasgerstmayr
approved these changes
Apr 30, 2024
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> Add duration of services in the jaeger query list Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
rubenvp8510
force-pushed
the
add_ttl_to_services
branch
from
82233e5
to
08df0f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on : #900