Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add interoperability tests for Tempo and OpenShift Serverless #923

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

IshwarKanse
Copy link
Contributor

@IshwarKanse IshwarKanse commented May 9, 2024

  • The PR adds interop tests for Tempo and OpenShift Serverless integration.
  • Bump the Chainsaw version to v0.2.4
--- PASS: chainsaw (799.67s)
    --- PASS: chainsaw/otel-tempo-serverless (401.78s)
    --- PASS: chainsaw/tempo-serverless (397.89s)
PASS
Tests Summary...
- Passed  tests 2
- Failed  tests 0
- Skipped tests 0
Done.

@IshwarKanse IshwarKanse marked this pull request as draft May 9, 2024 10:59
@IshwarKanse IshwarKanse changed the title Add interoperability tests for Tempo and OpenShift Serverless [Chore] Add interoperability tests for Tempo and OpenShift Serverless May 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ca84dd2). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage        ?   76.51%           
=======================================
  Files           ?       94           
  Lines           ?     6071           
  Branches        ?        0           
=======================================
  Hits            ?     4645           
  Misses          ?     1153           
  Partials        ?      273           
Flag Coverage Δ
unittests 76.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IshwarKanse IshwarKanse marked this pull request as ready for review June 20, 2024 12:32
@@ -0,0 +1,89 @@
apiVersion: chainsaw.kyverno.io/v1alpha1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we really need this E2E test because the OpenTelemetry Collector is just forwarding the traces. It should be enough with the direct Tempo integration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Serverless docs document both scenarios. https://docs.openshift.com/serverless/1.32/observability/tracing/serverless-tracing.html .I have added both to detect any regression if anything changes for the components used.

@IshwarKanse
Copy link
Contributor Author

IshwarKanse commented Jun 24, 2024

@rubenvp8510 Fixed the upgrade test. Direct resource support was removed from Chainsaw 0.2.4 version. https://github.com/kyverno/chainsaw/releases/tag/v0.2.4 We now have to specify the apiVersion and kind for the resource. https://kyverno.github.io/chainsaw/latest/operations/helpers/get/

@iblancasa
Copy link
Collaborator

@andreasgerstmayr @rubenvp8510 can we merge this?

@andreasgerstmayr andreasgerstmayr merged commit 0ed0494 into grafana:main Jun 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants