-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Add interoperability tests for Tempo and OpenShift Serverless #923
Conversation
IshwarKanse
commented
May 9, 2024
•
edited
Loading
edited
- The PR adds interop tests for Tempo and OpenShift Serverless integration.
- Bump the Chainsaw version to v0.2.4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage ? 76.51%
=======================================
Files ? 94
Lines ? 6071
Branches ? 0
=======================================
Hits ? 4645
Misses ? 1153
Partials ? 273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,89 @@ | |||
apiVersion: chainsaw.kyverno.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we really need this E2E test because the OpenTelemetry Collector is just forwarding the traces. It should be enough with the direct Tempo integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Serverless docs document both scenarios. https://docs.openshift.com/serverless/1.32/observability/tracing/serverless-tracing.html .I have added both to detect any regression if anything changes for the components used.
@rubenvp8510 Fixed the upgrade test. Direct resource support was removed from Chainsaw 0.2.4 version. https://github.com/kyverno/chainsaw/releases/tag/v0.2.4 We now have to specify the apiVersion and kind for the resource. https://kyverno.github.io/chainsaw/latest/operations/helpers/get/ |
@andreasgerstmayr @rubenvp8510 can we merge this? |