Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce max trace size on query path #1225

Open
joe-elliott opened this issue Jan 13, 2022 · 2 comments
Open

Enforce max trace size on query path #1225

joe-elliott opened this issue Jan 13, 2022 · 2 comments
Labels
keepalive Label to exempt Issues / PRs from stale workflow

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
There has been some discussion before regarding how Tempo can protect itself from very large traces: #976, #1133. This request is specifically for Tempo to return an error if a trace exceeds max trace size on query. This will help prevent very large traces from OOMing components of the query path.

@joe-elliott joe-elliott added this to the v1.4 milestone Jan 13, 2022
@joe-elliott
Copy link
Member Author

This has already been implemented on the search path, but not the "trace by id" path. Given that we intend to make radical changes to our block format in the near future we've decided to punt on this one. Also note that we have made additional protections during compaction to prevent larger traces from being formed.

@joe-elliott joe-elliott removed this from the v1.4 milestone Apr 15, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Nov 17, 2022
@kvrhdn kvrhdn added keepalive Label to exempt Issues / PRs from stale workflow and removed stale Used for stale issues / PRs labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Label to exempt Issues / PRs from stale workflow
Projects
None yet
Development

No branches or pull requests

2 participants