Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate context through Compactor interfaces #13

Closed
joe-elliott opened this issue Feb 3, 2020 · 3 comments
Closed

Propagate context through Compactor interfaces #13

joe-elliott opened this issue Feb 3, 2020 · 3 comments

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Feb 3, 2020 •
edited
Loading

Propagate Context appropriately and add tracing support.

Read this: https://blog.golang.org/context and do non-dumb things.
@joe-elliott
Copy link
Member Author

Query path only should be traced. Also note that we are currently recording a lot of traces, but not sampling them. This is likely a performance hit.

# HELP jaeger_tracer_started_spans_total Number of spans started by this tracer as sampled
# TYPE jaeger_tracer_started_spans_total counter
jaeger_tracer_started_spans_total{sampled="delayed"} 0
jaeger_tracer_started_spans_total{sampled="n"} 8.093228e+06
jaeger_tracer_started_spans_total{sampled="y"} 0

@joe-elliott joe-elliott changed the title Propagate Context and Add Tracing Trace Query Path Mar 12, 2020
@annanay25 annanay25 changed the title Trace Query Path Propagate context through Reader and Compactor interfaces Sep 2, 2020
@annanay25 annanay25 self-assigned this Sep 2, 2020
@joe-elliott
Copy link
Member Author

joe-elliott commented Oct 19, 2020 •
edited by annanay25
Loading

Reader is done in #179. Changing title to only require compactor.

@joe-elliott joe-elliott changed the title Propagate context through Reader and Compactor interfaces Propagate context through Compactor interfaces Oct 19, 2020
@annanay25 annanay25 removed their assignment Oct 21, 2020
@annanay25
Copy link
Contributor

No longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joe-elliott @annanay25