Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Traces created on Ingester crash/restart #15

Closed
joe-elliott opened this issue Feb 4, 2020 · 1 comment · Fixed by #181
Closed

Duplicate Traces created on Ingester crash/restart #15

joe-elliott opened this issue Feb 4, 2020 · 1 comment · Fixed by #181

Comments

@joe-elliott
Copy link
Member

The ingester is designed to keep completed/flushed blocks for a configurable time period after it has been flushed. This time period exists to allow the queriers to pull new blocklists successfully before an ingester "forgets" a trace as well as to provide faster lookups on recent traces.

However, these completed blocks are stored in the wal folder. If an ingester restarts it will replay all of these traces locally and re-flush them to the backend.

@joe-elliott joe-elliott changed the title Duplicate Traces created on Ingester crash Duplicate Traces created on Ingester crash/restart Feb 5, 2020
@joe-elliott
Copy link
Member Author

Proposal:
After a block is flushed to the backend move it to a folder named flushed beneath the wal folder. On startup clear the flushed folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant