Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snake case for Azure backend configuration #1879

Closed
faustodavid opened this issue Nov 9, 2022 · 1 comment · Fixed by #1883
Closed

Snake case for Azure backend configuration #1879

faustodavid opened this issue Nov 9, 2022 · 1 comment · Fixed by #1883

Comments

@faustodavid
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Azure backend naming convention is with "-" and the other backends are snake case. This might make it tricky when writing or reading documentation.

For example, the following sample code won't work with azure.
https://github.com/grafana/tempo/blob/main/docs/tempo/website/configuration/parquet.md?plain=1#L47

Describe the solution you'd like
Use snake case in the azure backend configuration file
https://github.com/grafana/tempo/blob/main/tempodb/backend/azure/config.go

Additional context
This will be a breaking change for current Tempo users that uses Azure as the backend. If the team is OK with this, I can create a PR to update the docs and the configuration file.

@joe-elliott
Copy link
Member

Yup. I've been meaning to address this for a long time. If you have the time @faustodavid a PR would be much appreciated to correct this. Since we're about to cut 2.0 it would be a good time for a breaking change.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants