Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics-generator] Use semantic Prometheus translation of attributes/labels #2177

Closed
3 tasks
mapno opened this issue Mar 7, 2023 · 1 comment
Closed
3 tasks
Assignees

Comments

@mapno
Copy link
Member

mapno commented Mar 7, 2023

In the metrics-generator, to convert span and resource attributes to Prometheus labels, we just sanitize them. Which involves of substituting . with _.

While that is correct, the Prometheus spec further specifies how some resource attributes should be used. This means, that in order to properly follow the spec, we need to change two translations

  • span service.instance.id to metric instance
  • span service.name to metric job
  • span service.namespace to metric job, if service.name is not present
@Jxlam-pdx
Copy link

This is a dup of #199

@ie-pham ie-pham closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archived
Development

No branches or pull requests

4 participants