Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make s3 timeout configurable #2346

Closed
joe-elliott opened this issue Apr 18, 2023 · 2 comments
Closed

Make s3 timeout configurable #2346

joe-elliott opened this issue Apr 18, 2023 · 2 comments
Assignees
@zalegrala

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
The s3 timeout is currently hardcoded to be minio default: https://github.com/grafana/tempo/blob/main/tempodb/backend/s3/s3.go#L365

Let's wire up a configurable timeout here.

Also, please backport this to 2.1.
@zalegrala zalegrala mentioned this issue Apr 19, 2023
Closed
3 tasks
@zalegrala
Copy link
Contributor

I'm planning to close this out as incomplete unless someone speaks up that they want to see this feature.

@zalegrala
Copy link
Contributor

Closing out. If someone wants this, please speak up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zalegrala zalegrala

Labels
None yet
Projects
Tempo squad
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plumb s3 dial context options into the config zalegrala/tempo
2 participants
@joe-elliott @zalegrala