Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_outstanding_per_tenant config worng #2444

Closed
lovesharepc opened this issue May 9, 2023 · 3 comments
Closed

max_outstanding_per_tenant config worng #2444

lovesharepc opened this issue May 9, 2023 · 3 comments
Assignees
Labels
keepalive Label to exempt Issues / PRs from stale workflow type/docs Improvements or additions to documentation

Comments

@lovesharepc
Copy link

Describe the bug
follow doc
https://grafana.com/docs/tempo/latest/configuration/#:~:text=max_outstanding_per_tenant

query_frontend:
  search:
    max_outstanding_per_tenant: 10000

will get error

failed parsing config: failed to parse configFile /etc/tempo.yaml: yaml: unmarshal errors:
line 100: field max_outstanding_per_tenant not found in type frontend.SearchConfig

use api check
real config is

query_frontend:
  max_outstanding_per_tenant: 10000
  search:
    

To Reproduce

Expected behavior

Environment:

  • Infrastructure: [docker]
  • Deployment tool: [docker]

Additional Context

tempo, version 2.1.1 (branch: HEAD, revision: 4157d7620)
  build user:       
  build date:       
  go version:       go1.20.3
  platform:         linux/amd64
  tags:             unknown
@joe-elliott joe-elliott added the type/docs Improvements or additions to documentation label May 9, 2023
@joe-elliott
Copy link
Member

joe-elliott commented May 9, 2023

Nice, Thanks for the report!

cc @knylander-grafana

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Jul 16, 2023
@joe-elliott joe-elliott added keepalive Label to exempt Issues / PRs from stale workflow and removed stale Used for stale issues / PRs labels Jul 17, 2023
@knylander-grafana
Copy link
Contributor

Thank you for reporting this!

I searched through the doc and max_outstanding_per_tenant is listed in three files:

  • configuration/_index.md (page you highlighted) - Fixed in latest release.
  • backend_search.md - Indent is correct
  • manifest.md (auto-generated) - Indent is correct

I don't think we need any additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Label to exempt Issues / PRs from stale workflow type/docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants