Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Tail-based sampling not working #2455

Closed
lovesharepc opened this issue May 6, 2023 · 6 comments · Fixed by #3167
Closed

[DOC] Tail-based sampling not working #2455

lovesharepc opened this issue May 6, 2023 · 6 comments · Fixed by #3167
Assignees
Labels
keepalive Label to exempt Issues / PRs from stale workflow type/docs Improvements or additions to documentation

Comments

@lovesharepc
Copy link

lovesharepc commented May 6, 2023

I reference this doc https://grafana.com/docs/tempo/latest/configuration/grafana-agent/tail-based-sampling/

  1. doc is old
    current config need like this
      tail_sampling:
        decision_wait: 10s
        num_traces: 100
        expected_new_traces_per_sec: 10
        policies:
          [
            {
              name: errors-policy,
              type: status_code,
              status_code: { status_codes: [ERROR] },
            }
          ]
  1. don't work
    I use otel/opentelemetry-collector-contrib:0.76.1
    with same tail_sampling config
    sampling can work
    use grafana agent is not
    grafana agent version
root@grafana-agent:/# grafana-agent --version 
agent, version main-d9462f2 (branch: main, revision: d9462f27)
  build user:       root@buildkitsandbox
  build date:       2023-05-05T22:32:14Z
  go version:       go1.20.3
  platform:         linux/amd64
  tags:             netgo,builtinassets,promtail_journal_enabled
@rfratto
Copy link
Member

rfratto commented May 10, 2023

Hi, thanks for reporting. The page you've linked is under Tempo, so I'm moving this to the Tempo repository.

@rfratto rfratto transferred this issue from grafana/agent May 10, 2023
@joe-elliott joe-elliott added the type/docs Improvements or additions to documentation label May 10, 2023
@joe-elliott
Copy link
Member

It will be very difficult for us to keep up with Agent docs going forward. I think we should mention the Agent in Tempo docs as a first class telemetry pipeline to be used with Grafana Cloud Traces/OSS Tempo and then link to their docs.

wdyt @knylander-grafana ?

@lovesharepc
Copy link
Author

thank for reply
actually, I hope is grafana agent can update include's opentelemetry collector to keep feature work
doc can just link to official doc

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Jul 16, 2023
@joe-elliott joe-elliott added keepalive Label to exempt Issues / PRs from stale workflow and removed stale Used for stale issues / PRs labels Jul 17, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added stale Used for stale issues / PRs and removed stale Used for stale issues / PRs labels Oct 12, 2023
@knylander-grafana
Copy link
Contributor

knylander-grafana commented Jan 16, 2024

Doc PR - #3167

@joe-elliott There are two trains of thought on the Agent doc that's in Tempo. We can move it to the Agent doc area with flags for Tempo, which then means Tempo users have to go to a different doc set. We can keep it in Tempo, or single source it and share it between Agent and Tempo.

@knylander-grafana knylander-grafana changed the title Tail-based sampling not working [DOC] Tail-based sampling not working Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Label to exempt Issues / PRs from stale workflow type/docs Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants