Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take trace_state into account when calculating span metrics #2684

Open
joe-elliott opened this issue Jul 21, 2023 · 5 comments
Open

Take trace_state into account when calculating span metrics #2684

joe-elliott opened this issue Jul 21, 2023 · 5 comments
Labels
component/metrics-generator enhancement New feature or request keepalive Label to exempt Issues / PRs from stale workflow

Comments

@joe-elliott
Copy link
Member

When using w3c tracing context propagation OTel will propagate "trace state" here:

https://github.com/open-telemetry/opentelemetry-proto/blob/c4dfbc51f3cd4089778555a2ac5d9bc093ed2956/opentelemetry/proto/trace/v1/trace.proto#L100

The data in this string can contain information about how the trace was sampled:

https://opentelemetry.io/docs/specs/otel/trace/tracestate-probability-sampling/

If this information is present it can be used to reverse the impact of sampling. Add a configuration option that, when set to true, checks for trace state and uses it to inflate metrics to "undo" sampling.

@joe-elliott joe-elliott added keepalive Label to exempt Issues / PRs from stale workflow help wanted Extra attention is needed labels Jul 25, 2023
@joe-elliott joe-elliott removed the help wanted Extra attention is needed label Aug 2, 2023
@joe-elliott
Copy link
Member Author

Let's hold on this. I've heard that the linked tracestate documentation is up for debate now in OTEL. After they've settled on how to communicate this information we can revisit.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added stale Used for stale issues / PRs and removed stale Used for stale issues / PRs labels Oct 12, 2023
@adirmatzkin
Copy link
Contributor

Should we add a keep-alive label? 😊 @joe-elliott

@joe-elliott
Copy link
Member Author

It looks like it has a keepalive label? Not sure what happened there.

@gavin-jeong
Copy link

Any updates? want to take root span name info with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics-generator enhancement New feature or request keepalive Label to exempt Issues / PRs from stale workflow
Projects
Status: Todo
Development

No branches or pull requests

3 participants