-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need a way to stop tempo from using dual stack urls for s3 backend #3720
Comments
Facing the same issue |
1 similar comment
Facing the same issue |
Same here :(. |
Hi! We use minio-go as client in Tempo for S3. The ability to enable/disable dualstack endpoints was recently added and seems to already be available in the latest release. Support for this in Tempo would require updating the client and adding a new config option for S3 backends to control it. Would you be up for this change? |
Yes, certainly up for the change, this has significant cost impact for us. Can you please guide us through the process |
You'll need to update the library minio/minio-go to the v7.0.70 release (you can run There is also a contributing guide if you have more general questions. |
@mapno, firstly thanks for the suggestion, but a further question being.. we have disabled minio explicitly to be used with tempo. So does tempo use minio internally to compact and send blocks over to s3 ?? |
No, we use minio-go, which is a "client SDK for S3 compatible object storage". It's just a library to connect to S3-compatible backends. |
@mapno The |
I'm not sure I understand what you mean. S3 dualstack endpoints are configured via the method (function) |
Hi @mapno , Had there been any updates on the functionality implementation part. We're also facing a similar issue and It'd greatly help our use case to not use s3 on a |
Hi. Yes, you're welcomed to open a new PR or continue this one #3721. I believe I've explained what needs to be done in the multiple comments in the PR (see #3721 (comment)). Thanks! |
Tempo compactor using s3 dualstack urls to interact with s3 backend storage, need a way to turn this behaviour off
To Reproduce
Steps to reproduce the behaviour:
tempo-distributed-1.9.1 2.4.1
Expected behaviour
Environment:
The text was updated successfully, but these errors were encountered: