Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compactors should Round Robin tenants #420

Closed
joe-elliott opened this issue Dec 16, 2020 · 0 comments · Fixed by #426
Closed

Compactors should Round Robin tenants #420

joe-elliott opened this issue Dec 16, 2020 · 0 comments · Fixed by #426
Assignees
@mdisibio

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently compactors randomly choose a tenant to compact. They should round robin tenants for fairness.

https://github.com/grafana/tempo/blob/master/tempodb/compactor.go#L73

Describe the solution you'd like

  • Make compactors round robin tenants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdisibio mdisibio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iterate through tenants for compaction instead of choosing randomly mdisibio/tempo
2 participants
@joe-elliott @mdisibio