Permissions: Support service account in user_id field
#1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
inkel
approved these changes
Sep 25, 2023
julienduchesne
force-pushed
the
julienduchesne/permissions-service-accounts
branch
from
1e09622
to
f71e18a
Compare
Closes #994 This seems like an undocumented feature that's known to users. You can set a service account ID in the `user_id` field of permissions resources In this PR: - Make this behavior work with the new ID format (`<org>:<id>`) - Document that the field supports an SA - Add tests to make sure we don't regress it again
julienduchesne
force-pushed
the
julienduchesne/permissions-service-accounts
branch
from
f71e18a
to
0a0faab
Compare
julienduchesne
deleted the
julienduchesne/permissions-service-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994
This seems like an undocumented feature that's known to users. You can set a service account ID in the
user_idfield of permissions resourcesIn this PR:
<org>:<id>)