Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry by default on 401s #1130

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Retry by default on 401s #1130

merged 1 commit into from
Nov 10, 2023

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Nov 6, 2023

These errors come up a lot during testing
It seems like Grafana may fail to authenticate users when lots of requests are being processed

Copy link

github-actions bot commented Nov 6, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review November 6, 2023 23:09
@julienduchesne julienduchesne requested a review from a team as a code owner November 6, 2023 23:09
@mhulscher
Copy link

@julienduchesne might I suggest you add a retry on 400 as well? See: grafana/grafana#77462 . After a retry (another terraform apply), the apply succeeds.

Seems like these come up a lot during testing
It seems like Grafana may fail to authenticate users when lots of requests are being processed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants