OpenAPI Client: Clone before modifying org ID #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs grafana/grafana-openapi-client-go#27 to be merged and ref to be changed in go.mod before merging Closes #1125 In a parallel context where both the main org (id 0) and non-main orgs are being called, the wrong client may be used To fix this, we can clone the client everytime we modify it. This will make sure we avoid conflicts, since we're never modifying the main reference (created in provider.go)
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
inkel
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs grafana/grafana-openapi-client-go#27 to be merged and ref to be changed in go.mod before merging
Closes #1125
In a parallel context where both the main org (id 0) and non-main orgs are being called, the wrong client may be used
To fix this, we can clone the client everytime we modify it. This will make sure we avoid conflicts, since we're never modifying the main reference (created in provider.go)