Cloud: Optimize Cloud SA operations #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `cloud_stack_(service_account|api_key)` resources create a temporary service account for all operations (The cloud API doesn't proxy the full CRUD) However, for operations like Create and Update, two SAs are created because it's customary to read after write in TF This PR changes the logic so that we only one temporary key is created
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
spinillos
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
cloud_stack_(service_account|api_key)resources create a temporary service account for all operations (The cloud API doesn't proxy the full CRUD)However, for operations like Create and Update, two SAs are created because it's customary to read after write in TF
This PR changes the logic so that we only one temporary key is created