Fix contact point notifier update #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps #769, not a full fix though When a contact point gets all of its notifiers deleted, it's functionally deleted in the API This shouldn't happen when updating, so in order to prevent that, we can add new notifiers and delete the old ones only at the end of the process Doing things in that order ensures that there will always be one notifier active since there's a TF resource validation that there should be at least one notifier
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #769, not a full fix though (a contact point should always be deletable on its own)
When a contact point gets all of its notifiers deleted, it's functionally deleted in the API.
This shouldn't happen when updating, so in order to prevent that, we can add new notifiers at the beginning of the update and delete the old ones only at the end of the process
Doing things in that order ensures that there will always be one notifier active since there's a TF resource validation that there should be at least one notifier