Fix provider error preventing all operations in v2.12.0 #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1372 I will do another PR afterwards with a test that verifies that this does not happen again
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
julienduchesne
added a commit
that referenced
this pull request
Feb 26, 2024
This reverts commit 093a34d.
julienduchesne
added a commit
that referenced
this pull request
Feb 26, 2024
…)" This reverts commit 7d069e9.
julienduchesne
added a commit
that referenced
this pull request
Feb 26, 2024
* Add full integration test During last release, the provider was unusable due to a provider config error None of the tests caught it. This adds an integration test make target which actually installs the provider and tries to use it This test fails on v2.12.0 but succeeds on v2.12.1 and main, as expected * Revert "Fix provider error preventing all operations in v2.12.0 (#1373)" This reverts commit 093a34d. * Reapply "Fix provider error preventing all operations in v2.12.0 (#1373)" This reverts commit 7d069e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1372
I will do another PR afterwards with a test that verifies that this does not happen again