Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional cloudwatch options #16

Closed
wants to merge 2 commits into from

Conversation

Fitzsimmons
Copy link

This should satisfy the requirements of #14.

Justin Fitzsimmons added 2 commits March 21, 2018 17:30
* custom_metrics_namespaces and assume_role_arn now supported
* changes vendored version of go-grafana-api until upstream merges the
  relevant pull request
@pearkes
Copy link
Contributor

pearkes commented Mar 24, 2018

This LGTM. After merging the changes in #17 I get a clean test run:

$ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?   	github.com/terraform-providers/terraform-provider-grafana	[no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccAlertNotification_basic
--- PASS: TestAccAlertNotification_basic (0.72s)
=== RUN   TestAccDashboard_basic
--- PASS: TestAccDashboard_basic (0.44s)
=== RUN   TestAccDashboard_disappear
--- PASS: TestAccDashboard_disappear (0.37s)
=== RUN   TestAccDataSource_basic
--- PASS: TestAccDataSource_basic (0.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-grafana/grafana	2.214s

@pearkes
Copy link
Contributor

pearkes commented Mar 24, 2018

Actually it may also be good to add a test case for this as well.

@pearkes
Copy link
Contributor

pearkes commented Apr 16, 2018

Thanks @Fitzsimmons I rebased and merged this to master, added tests specific to cloudwatch. hashicorp/terraform-provider-grafana@8f85117...master

@pearkes pearkes closed this Apr 16, 2018
@mlclmj mlclmj mentioned this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants