Bug fix: Add global field when updating a role. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating a fine-grained access control role, Grafana checks if the role at question has global scope or not. If global field is not specified in the role definition, Grafana will always assume that the role is not global, which will result to failure when updating global roles.
julienduchesne
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Seems like the current tests should already cover this case but I actually don't know how to run them 😬 . I really have to get #294 done
Jguer
approved these changes
Jan 13, 2022
|
Have run the tests, the one that covers this fails in the main branch, passes in this one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a fine-grained access control role, Grafana checks if the role at question has global scope or not.
If global field is not specified in the role definition, Grafana will always assume that the role is not global,
which will result to failure when updating global roles.
Note for the reviewers
The role update is a Grafana Enterprise feature, these code lines are the guardians which will cause the failure without the
globalflat set correctly.