Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SM: Use new GetCheck and GetProbe functions #339

Merged
merged 1 commit into from
Jan 14, 2022
Merged

SM: Use new GetCheck and GetProbe functions #339

merged 1 commit into from
Jan 14, 2022

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Jan 14, 2022 •
edited

Added in client 0.4.0: #338
Makes code a bit cleaner

@julienduchesne julienduchesne marked this pull request as ready for review January 14, 2022 11:40
@julienduchesne julienduchesne requested a review from a team as a code owner January 14, 2022 11:40
inkel
inkel approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Definitely easier to read.

@julienduchesne julienduchesne merged commit 9302c99 into master Jan 14, 2022
@julienduchesne julienduchesne deleted the julienduchesne/sm-client-new-funcs branch January 14, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkel inkel inkel approved these changes

@mem mem Awaiting requested review from mem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @inkel