Update resource_builtin_role_assignment resource to ignore assignments defined in the server side #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
approved these changes
Feb 3, 2022
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| ProviderFactories: testAccProviderFactories, | ||
| CheckDestroy: testAccBuiltInRoleAssignmentCheckDestroy(&br), |
There was a problem hiding this comment.
Should the CheckDestroy function also check that the default assignements weren't destroyed?
There was a problem hiding this comment.
Really good catch. I actually just realized that testAccBuiltInRoleAssignmentCheckDestroy checks nothing, as the pointer to &br never updates to the created built-in role assignment, so we always pass an empty struct to the method, which returns success on it's turn as there is indeed no assignment for empty built-in role.
Working on a fix.
Jguer
reviewed
Feb 3, 2022
Jguer
reviewed
Feb 3, 2022
Jguer
reviewed
Feb 3, 2022
Jguer
reviewed
Feb 3, 2022
Jguer
approved these changes
Feb 3, 2022
inkel
reviewed
Feb 3, 2022
…s defined in the server side When Grafana starts, by default it creates built-in role assignments for fixed roles. Additionally, users can create built-in role assignments via API. In these scenarios, when the resource is not properly imported, terraform will try to destroy what is in server side, but not in the configuration. The change ensures that this does not happen as it can cause unintended behaviour for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When Grafana starts, by default it creates built-in role assignments for fixed roles. Additionally, users can create built-in role assignments via API. In these scenarios, when the resource is not properly imported, terraform will try to destroy what is in server side, but not in the configuration.
The change ensures that this does not happen as it can cause unintended behaviour for users.
Implementation details
The only workaround, with the given resources is to do in advance check to see if the fetched assignments has been ever in the state, or is present in the configuration, otherwise ignore it.
Testing
I have manually tested the following scenarios:
Additionally, the newly added test covers the scenario mentioned in the issue.
Related issues
Fixes #362