Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Sentry attributes #373

Merged
merged 5 commits into from Feb 7, 2022
Merged

Add missing Sentry attributes #373

merged 5 commits into from Feb 7, 2022

Conversation

inkel
Copy link
Contributor

@inkel inkel commented Feb 3, 2022

Fixes #346

@inkel inkel self-assigned this Feb 3, 2022
@inkel inkel requested a review from a team as a code owner February 3, 2022 15:21
@inkel inkel force-pushed the add-missing-sentry-attributes branch from 1a5d566 to 8885d69 Compare February 3, 2022 15:24
@inkel
Copy link
Contributor Author

inkel commented Feb 4, 2022

🤔 well, it didn't like orgSlug and authToken because field name may only contain lowercase alphanumeric characters & underscores.

@julienduchesne
Copy link
Member

🤔 well, it didn't like orgSlug and authToken because field name may only contain lowercase alphanumeric characters & underscores.

They should be org_slug and auth_token

@inkel
Copy link
Contributor Author

inkel commented Feb 4, 2022

Yeah, I'm about to make the change.

inkel added a commit to grafana/grafana-api-golang-client that referenced this pull request Feb 4, 2022
@inkel
Add Sentry datasource attributes
fd7767b 
This is required for grafana/terraform-provider-grafana#373

Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
@inkel inkel mentioned this pull request Feb 4, 2022
Merged
@inkel
Copy link
Contributor Author

inkel commented Feb 4, 2022

This is blocked until we merge and release the Go client.

inkel and others added 3 commits February 4, 2022 13:46
@inkel @julienduchesne
Add missing Sentry attributes
43591e1 
Fixes #346

Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
@inkel @julienduchesne
Properly case Sentry attributes and pass them to client
0373a2b 
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
@julienduchesne
go generate
c2debf1
@inkel
Copy link
Contributor Author

inkel commented Feb 7, 2022

This now depends on grafana/grafana-api-golang-client#58 because we've found an issue on how the provider treats the url attribute.

@inkel
Fix tests
080de4c 
Now we respect the URL attribute for Sentry, it is the underlying
client the one that sends it as a JSON payload attribute.

Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
@inkel inkel merged commit 7f84755 into master Feb 7, 2022
@inkel inkel deleted the add-missing-sentry-attributes branch February 7, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienduchesne julienduchesne julienduchesne approved these changes

Assignees

@inkel inkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Sentry Plugin
2 participants
@inkel @julienduchesne