add data_source_dashboards

[justinTM]

builds haven't been initiating so trying new fresh branch

[justinTM]

@inkel builds don't appear to be working

[inkel]

Hi, @justinTM, thanks again for your contributions. I've got a question: how's this PR different from #378? Both have the same title and seem to be adding the same kind of data source.

Also, I'm not so sure about this one. We already have a grafana_dashboard data source introduced in #359, I think we should in any case extend that one to allow for returning more than one result instead.

Let's stop development on this one temporarily while we discuss it with the rest of the maintainers.

Thanks!

[justinTM]

hey @inkel , they are virtually the same PRs; i was trying to see if i could trigger the CI build using a different branch.

i would love to pause development honestly, but unfortunately there is a vulnerability in the way grafana provisioning (with terraform) mixes with user-created dashboards: dashboards in provisioned folders will be lost forever. the organization i'm working with has been experiencing this issue with increasing frequency lately.

from a development standpoint, i'm testing cURL requests directly to the API with good (sometimes unexpected) results. i would just use shell commands in the project but keeping everything maintained by terraform is preferable.

data_source_dashboard.go could be made responsible for getting all dashboards, but currently that would require refactoring the required inputs (for id, uid, etc.). the way the aws provider seems to do it -- similar to Trott's probes datasource -- is to make them separate:

• buckets https://github.com/hashicorp/terraform-provider-aws/blob/187f1659a4fef11ac314567273b5470afe6b662f/internal/service/s3/bucket_object_data_source.go
• bucket https://github.com/hashicorp/terraform-provider-aws/blob/187f1659a4fef11ac314567273b5470afe6b662f/internal/service/s3/bucket_objects_data_source.go

if i can refactor the dashboard folder search function in the client and use it successfully, i think this PR will be ready for review.

[justinTM]

@inkel wow what a relief. I finally figured it out. There's a bug in the testing framework from Hashicorp: hashicorp/terraform-plugin-sdk#885

[justinTM]

hey @inkel our team needs this ASAP if I could bother you for a review.

[julienduchesne]

hey @inkel our team needs this ASAP if I could bother you for a review.

Hey @justinTM. Unfortunately, the provider is only one of our responsibilities within Grafana Labs. We actively watch PRs with passing checks and we'll eventually get to yours when we get the time. Thanks for your patience!

[justinTM]

the tests are passing

[justinTM]

@julienduchesne do you know of a way to utilize a forked repo without publishing to the Hashicorp Registry?

[julienduchesne]

@julienduchesne do you know of a way to utilize a forked repo without publishing to the Hashicorp Registry?

You can write custom versions of a provider (or completely create a new one) locally

Here's what I use from my repo:

go build && cp ./terraform-provider-grafana ~/.terraform.d/plugins/registry.terraform.io/grafana/grafana/999.999.999/darwin_amd64/terraform-provider-grafana

Then my Grafana config looks like this:

terraform {
  required_providers {
    grafana = {
      source = "grafana/grafana"
    }
  }
}

provider "grafana" {
  url  = "http://localhost:3000"
  auth = "admin:admin"
}

[inkel]

As an alternative, if you use terraform CLI tool you can override the provider installation via a configuration file.

[inkel]

Upon first review looks quite good, however, we cannot accept the replace directive in go.mod.

[justinTM]

@inkel i know, it's just to get passing tests until client PR is merged

[justinTM]

must be merged together with grafana/grafana-api-golang-client#59

i'll remove the replace directive in anticipation

[julienduchesne]

LGTM modulo rebasing on master + the two comments I added

[justinTM]

https://drone.grafana.net/grafana/terraform-provider-grafana/773

[inkel]

LGTM. Thanks for your work and patience!

[inkel]

Just out of curiosity, any reason why returning just 24 characters?