Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changelog entries for v1.14.0+ #381

Merged
merged 1 commit into from Feb 8, 2022

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Feb 7, 2022

The changelog renderer doesn't know the difference between a closed issue and a resolved one so it adds confusing things to the log
Ex: we currently have Resource to control the new style of alerting provided in Grafana 8.X #348 in the v1.19.0 changelog but that's only going to be released with Grafana 8.5
The release notes builder that comes in Github Releases produces a much nicer result so let's only use that
It also simplifies the release process, no need for a Github token

The changelog renderer doesn't know the difference between a closed issue and a resolved one so it adds confusing things to the log
Ex: we currently have `Resource to control the new style of alerting provided in Grafana 8.X #348` in the v1.19.0 changelog
The release notes builder that comes in Github Releases produces a much nicer result so let's only use that
It also simplifies the release process, no need for a Github token
@julienduchesne julienduchesne requested a review from a team as a code owner February 7, 2022 20:50
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@julienduchesne julienduchesne merged commit d4dcf20 into master Feb 8, 2022
@julienduchesne julienduchesne deleted the julienduchesne/remove-changelogs branch February 8, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants