Fix grafana_team members reordering
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's managed as a set by the Grafana API (and client) but we have it as a list in the resource This means that whenever the ordering change, it's not being pushed to the API and we have a drift (see issue for more info) This makes the members attribute a set. Migration is not an issue since both lists and sets are represented as JSON lists in the state (I tested it) Closes #384
julienduchesne
deleted the
julienduchesne/fix-team-members-reordering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's managed as a set by the Grafana API (and client) but we have it as a list in the resource
This means that whenever the ordering change, it's not being pushed to the API and we have a drift (see issue for more info)
This makes the members attribute a set. Migration is not an issue since both lists and sets are represented as JSON lists in the state (I tested it)
Closes #384