Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing org_id of resource grafana_organization #392

Merged
merged 2 commits into from Feb 16, 2022

Conversation

pallxk
Copy link
Contributor

@pallxk pallxk commented Feb 16, 2022

Test terraform config

terraform {
  required_providers {
    grafana = {
      source = "grafana/grafana"
    }
  }
}

resource "grafana_organization" "org_2" {
  name = "org_2"
}

output "org_id" {
  value = grafana_organization.org_2.org_id
}

Before

$ terraform output
╷
│ Warning: No outputs found
│ 
│ The state file either has no outputs defined, or all the defined outputs are empty. Please define an output in your configuration with the `output` keyword and run `terraform refresh` for it to become available. If you are
│ using interpolation, please verify the interpolated value is not empty. You can use the `terraform console` command to assist.
╵

After

$ terraform output
org_id = 2

@pallxk pallxk requested a review from a team as a code owner February 16, 2022 03:31
@julienduchesne julienduchesne self-assigned this Feb 16, 2022
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @pallxk! I also added a test which lead me to find another bug 😄

@julienduchesne julienduchesne merged commit fa71eb3 into grafana:master Feb 16, 2022
@pallxk pallxk deleted the fix-grafana-org-id branch February 17, 2022 00:25
@pallxk
Copy link
Contributor Author

pallxk commented Feb 17, 2022

Great to have things tested! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants