Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json_data field types for opentsdb datasource #398

Merged
merged 3 commits into from Feb 21, 2022
Merged

Fix json_data field types for opentsdb datasource #398

merged 3 commits into from Feb 21, 2022

Conversation

julienduchesne
Copy link
Member

Supersedes #141
Closes #140

tsdb_resolution and tsdb_version were declared as strings though
those fields are integers.

@julienduchesne
Fix json_data field types for opentsdb datasource
ffee5aa 
`tsdb_resolution` and `tsdb_version` were declared as strings though
those fields are integers.
@julienduchesne julienduchesne mentioned this pull request Feb 21, 2022
Closed
@julienduchesne julienduchesne marked this pull request as ready for review February 21, 2022 16:29
@julienduchesne julienduchesne requested a review from a team as a code owner February 21, 2022 16:29
@julienduchesne
Copy link
Member Author

Tests are failing. I'll wait until grafana/grafana-api-golang-client#65 is merged and do a client release. Then I'll update the client here

inkel
inkel approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW changes LGTM.

@julienduchesne julienduchesne merged commit bbb20e9 into master Feb 21, 2022
@julienduchesne julienduchesne deleted the fix_opentsdb_ds branch February 21, 2022 17:17
@julienduchesne julienduchesne mentioned this pull request Feb 23, 2022
Closed
julienduchesne added a commit that referenced this pull request Feb 23, 2022
@julienduchesne
Migrate opentsdb string fields to int
fb7d551 
This fixes a migration bug introduced by #398
We unfortunately have to add a schema migration function to convert the strings to int
Since 1.20.0 is released, we cannot just go back to a string at this point, so a migration is the way forward

Fixes #400
We should release 1.20.1 once that's merged
@julienduchesne julienduchesne mentioned this pull request Feb 23, 2022
Merged
julienduchesne added a commit that referenced this pull request Feb 24, 2022
@julienduchesne
Migrate opentsdb string fields to int (#401)
b62ecac 
This fixes a migration bug introduced by #398
We unfortunately have to add a schema migration function to convert the strings to int
Since 1.20.0 is released, we cannot just go back to a string at this point, so a migration is the way forward

Fixes #400
We should release 1.20.1 once that's merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inkel inkel inkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTSDB datasource fields tsdb_resolution and tsdb_version have wrong type
2 participants
@julienduchesne @inkel