Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add support for Unified Alerting mute timings. #562

Merged
merged 18 commits into from
Aug 9, 2022

Conversation

alexweav
Copy link
Contributor

Adds support for mute timings. In draft, while a couple loose ends are tied up with the golang client.

go.mod Outdated Show resolved Hide resolved
@@ -177,7 +177,7 @@ func testAccPlaylistConfigBasic(name string) string {
resource "grafana_playlist" "test" {
name = %[1]q
interval = "5m"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple whitespace inconsistency that my editor kept wanting to fix.

Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few comments/questions.

grafana/resource_alerting_mute_timing.go Show resolved Hide resolved
grafana/resource_alerting_mute_timing.go Outdated Show resolved Hide resolved
grafana/resource_alerting_mute_timing.go Show resolved Hide resolved
@alexweav alexweav force-pushed the alexweav/alerting-mute-timings branch from 78c4b4c to 3cb9a89 Compare August 8, 2022 19:45
@alexweav alexweav merged commit 1874714 into master Aug 9, 2022
@alexweav alexweav deleted the alexweav/alerting-mute-timings branch August 9, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants