Add grafana_folders data source for fetching all folders
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
commented
Aug 10, 2022
mdb
commented
Aug 10, 2022
This seeks to address:
```
grafana/data_source_folders.go:5:2: G501: Blocklisted import crypto/md5: weak cryptographic primitive (gosec)
"crypto/md5"
^
grafana/data_source_folders.go:71:9: G401: Use of weak cryptographic primitive (gosec)
md5 := md5.Sum([]byte(strings.Join(uids, "-")))
^
```
Signed-off-by: Mike Ball <mikedball@gmail.com>
Per @julienduchesne (https://github.com/grafana/terraform-provider-grafana/pull/583/files#r944357467): > The ID should be declarative because it needs to be unique. For a datasource like this, it's usually the combination of all entry parameters because you will typically not have the same datasource twice with the same parameters, it's useless > With no parameters, you can just set the ID as grafana_folders. No need to calculate a SHA Signed-off-by: Mike Ball <mikedball@gmail.com>
Thanks @julienduchesne - I've implemented your suggestion, assuming I interpreted correctly :) |
Closed
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to address issue #377 by adding a
grafana_foldersdata source, which can be used to fetch all Grafana folders.Note that this is an alternative implementation to that contained in PR #389, which I admittedly only noticed just now (I apologize) and which appears to have gone stale with git conflicts and an unsigned CLA. Would maintainers prefer I close this PR in favor of the PR #389 implementation?