Alerting: Add support for opsgenie, pagerduty, pushover, and sensugo notifiers
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnnyQQQQ
reviewed
Aug 18, 2022
| DisableResolveMessage: disableResolve, | ||
| Settings: settings, | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we should start splitting this file moving forward as we do in Grafana.
There was a problem hiding this comment.
I agree, but I did not want to deviate from the current package structure in this project. These all have quite a bit less code than the actual notifier implementations so I felt it was ok.
JohnnyQQQQ
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the next batch of strongly-typed notifiers to the provider.
Extended the notifier interface a little - the marshalling code can now propagate arbitrary errors, which appear nicely in the Terraform output.