Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana OnCall: routing_type attribute for grafana_oncall_route resource (support Jinja2 templates) #892

Merged
merged 9 commits into from
Jun 26, 2023

Conversation

areh-dev
Copy link
Contributor

Add On-Call Jinja route support, described in issue issues #849 for recomended type of route matching

馃洃聽requires:

@areh-dev areh-dev requested a review from a team as a code owner April 21, 2023 00:31
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

@areh-dev
Copy link
Contributor Author

@iskhakov
Hi! Could you look at the PR that allows configure routes in Grafana OnCall by terraform in a convenient way through jinja2 templates?

@julienduchesne julienduchesne removed the request for review from a team June 8, 2023 13:17
@k5924
Copy link

k5924 commented Jun 21, 2023

Hi, was just wondering when this was expected to be reviewed as the grafana docs and grafana on call dashboard also recommends using Jinja? To my knowledge, there is no other workaround to get it working besides the one detailed in this github issue: #849

@iskhakov iskhakov self-assigned this Jun 22, 2023
@julienduchesne julienduchesne merged commit 1326a83 into grafana:master Jun 26, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants