Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing role from state if it does not exist #918

Merged
merged 1 commit into from
May 23, 2023

Conversation

skatsaounis
Copy link
Contributor

Fix the current provider state which fails to perform plan and also remove from state roles that do not exist anymore.

@skatsaounis skatsaounis requested a review from a team as a code owner May 23, 2023 10:10
@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

@skatsaounis
Copy link
Contributor Author

Current state

Error: status: 404, body: {"message":"Role not found","traceID":"123456"}

Expected behavior

Plan succeeds and also removes the deleted role from state.

Reason

The if condition checks for role rather than Role.

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@julienduchesne julienduchesne merged commit d04b644 into grafana:master May 23, 2023
2 of 3 checks passed
@skatsaounis skatsaounis deleted the fix-non-existing-role branch May 24, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants