Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana_contact_point: Force the use of at least one notifier #928

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

julienduchesne
Copy link
Member

Closes #797
Build a list of all notifier names and set AtLeastOneOf to make sure an empty contact point isn't created

Closes #797
Build a list of all notifier names and set `AtLeastOneOf` to make sure an empty contact point isn't created
@julienduchesne julienduchesne requested a review from a team as a code owner June 2, 2023 17:17
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

julienduchesne and others added 2 commits June 2, 2023 13:41
Co-authored-by: Leandro López <leandro.lopez@grafana.com>
@julienduchesne julienduchesne merged commit 9b1af7a into master Jun 5, 2023
3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/at-least-one-off-notifier branch June 5, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating grafana_contact_point with no destination results in Root resource was present, but now absent.
2 participants