Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that a stack's trace URL is the base URL #932

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

julienduchesne
Copy link
Member

Issue: #891

I will recommend that this user open an issue to grafana/grafana instead

  1. If the loki datasource supports a bare URL and not the tempo datasource, then it seems like a feature gap
  2. We can't change the traces URL now, it will break existing setups
  3. I think it's better to reflect what the API sends us

Issue: #891
I will recommend that this user open an issue to `grafana/grafana` instead
1. If the `loki` datasource supports a bare URL and not the tempo datasource, then it seems like a feature gap
2. We can't change the traces URL now, it will break existing setups
3. I think it's better to reflect what the API sends us
@julienduchesne julienduchesne requested a review from a team as a code owner June 5, 2023 16:35
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, we shouldn't change this, and in any case, the issue is in grafana/grafana and not the provider.

@julienduchesne julienduchesne merged commit 1859a18 into master Jun 12, 2023
3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/document-traces-url branch June 12, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants