Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Remove slug and its migration #967

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

julienduchesne
Copy link
Member

This field is no longer used and the migration was needed for Grafana 7 -> 8
I don't think we need to carry this code anymore. Especially considering that users can do a two-step upgrade if they do have issues

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

@julienduchesne julienduchesne marked this pull request as ready for review July 5, 2023 00:29
@julienduchesne julienduchesne requested a review from a team as a code owner July 5, 2023 00:29
This field is no longer used and the migration was needed for Grafana 7 -> 8
I don't think we need to carry this code anymore. Especially considering that users can do a two-step upgrade if they do have issues
@julienduchesne julienduchesne merged commit 7ce0806 into master Jul 5, 2023
2 of 3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/dashboard-slug branch July 5, 2023 14:01
github-merge-queue bot pushed a commit to panda-den/colorful-pandas that referenced this pull request Jul 6, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [grafana](https://registry.terraform.io/providers/grafana/grafana)
([source](https://togithub.com/grafana/terraform-provider-grafana)) |
required_provider | major | `1.43.0` -> `2.0.0` |

---

### Release Notes

<details>
<summary>grafana/terraform-provider-grafana (grafana)</summary>

###
[`v2.0.0`](https://togithub.com/grafana/terraform-provider-grafana/releases/tag/v2.0.0)

[Compare
Source](https://togithub.com/grafana/terraform-provider-grafana/compare/v1.43.0...v2.0.0)

#### What's Changed

- Datasource: Remove deprecated fields by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#963
- Remove deprecated resources by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#964
- Remove `cloud_stack_slug` attribute from API key by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#965
- Remove unused fields in `synthetic_monitoring_installation` by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#966
- Dashboard: Remove `slug` and its migration by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#967

**Full Changelog**:
grafana/terraform-provider-grafana@v1.43.0...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNi4xLjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: astronaut-panda[bot] <137164246+astronaut-panda[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants