Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource: Add org_id attribute #976

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

julienduchesne
Copy link
Member

Issue: #747
Allows a datasource to be created and managed in a separate organization without needing two provider blocks
Also adds tests that a datasource can be created and managed in an org

@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

Issue: #747
Allows a datasource to be created and managed in a separate organization without needing two provider blocks
Also adds tests that a datasource can be created and managed in an org
@julienduchesne julienduchesne marked this pull request as ready for review July 12, 2023 00:47
@julienduchesne julienduchesne requested a review from a team as a code owner July 12, 2023 00:47
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, but I've left some questions for things that I'm not understanding :yay:

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@julienduchesne julienduchesne merged commit 1269f4c into master Jul 12, 2023
3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/ds-org-id branch July 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants