Mark the global org_id as deprecated
#980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
julienduchesne
force-pushed
the
julienduchesne/mark-org-id-as-deprecated
branch
2 times, most recently
from
2e2eb15
to
de108f4
Compare
julienduchesne
added a commit
that referenced
this pull request
Jul 13, 2023
Once we remove `org_id` (Deprecated here: #980) The provider will need the org_id in state to reconcile. This PR makes sure that it is always set This will make the migration seamless for users (just modifying their TF statements and everything should work)
julienduchesne
added a commit
that referenced
this pull request
Jul 13, 2023
Once we remove `org_id` (Deprecated here: #980) The provider will need the org_id in state to reconcile. This PR makes sure that it is always set This will make the migration seamless for users (just modifying their TF statements and everything should work)
inkel
approved these changes
Jul 14, 2023
julienduchesne
added a commit
that referenced
this pull request
Jul 14, 2023
Once we remove `org_id` (Deprecated here: #980) The provider will need the org_id in state to reconcile. This PR makes sure that it is always set This will make the migration seamless for users (just modifying their TF statements and everything should work)
Reasons: - `org_id` does not work with all resources. Ex: `grafana_user` is not org-scoped, alerting resources have their own `org_id` attribute and the API is different where the global attribute does NOT work. This is very confusing for users - This allows us to make the docs lighter. Less options is simpler for users
julienduchesne
force-pushed
the
julienduchesne/mark-org-id-as-deprecated
branch
from
37d0bb3
to
797bf01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be merged once #979 is ready and also merged
Reasons:
org_iddoes not work with all resources. Ex:grafana_useris not org-scoped, alerting resources have their ownorg_idattribute and the API is different where the global attribute does NOT work. This is very confusing for users