Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence org_id deprecation warning when not using it #984

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Jul 14, 2023

The default value is making Terraform complain even if org_id isn't explicitly set

The default value is making Terraform complain even if `org_id` isn't specified
@julienduchesne julienduchesne requested a review from a team as a code owner July 14, 2023 17:37
@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@julienduchesne julienduchesne merged commit 5fd293e into master Jul 14, 2023
3 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/silence-deprecation-warning branch July 14, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants